1346 symbolic link between our projects and the library 1 #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…escript resolution
… the paths config
… 1346-symbolic-link-between-our-projects-and-the-library-1
alecarn
commented
Sep 11, 2023
| "input": "./node_modules/@igo2/core/locale/", | ||
| "output": "./locale/libs_locale", | ||
| "ignore": ["**/*.core.json"] | ||
| }, |
There was a problem hiding this comment.
Replace the scripts locale-copy-from-igo2-core
alecarn
commented
Sep 11, 2023
| "sourceMap": true | ||
| "sourceMap": true, | ||
| "paths": { | ||
| "@igo2/*": ["node_modules/@igo2/*", "../../packages/*/src/public_api"] |
There was a problem hiding this comment.
Workaround, when we refer to the symbolic link, we need to provide the source code for Typescript module resolution. We fallback on the last url if it exists.
alecarn
commented
Sep 20, 2023
| "start-pwa": "ng build --configuration pwa --output-path ./dist/pwa && npm run serve.pwa", | ||
| "build": "ng build", | ||
| "build.prod": "ng build --configuration production", | ||
| "link.start": "ng serve --configuration developpement-link", | ||
| "link.build": "ng build --configuration production-link", |
There was a problem hiding this comment.
link.start vs start.link?
…/igo2 into 1346-symbolic-link-between-our-projects-and-the-library-1
This is include in the Angular.json
…/igo2 into 1346-symbolic-link-between-our-projects-and-the-library-1
…/igo2 into 1346-symbolic-link-between-our-projects-and-the-library-1
…-1' of https://github.com/infra-geo-ouverte/igo2 into 1346-symbolic-link-between-our-projects-and-the-library-1
…ic-link-between-our-projects-and-the-library-1
pelord
approved these changes
Oct 31, 2023
… 1346-symbolic-link-between-our-projects-and-the-library-1
alecarn
deleted the
1346-symbolic-link-between-our-projects-and-the-library-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rearchitect the app structure to allow a symlink between our project and our packages library igo2-lib.
See this PR for more information